Opened 9 years ago

Closed 9 years ago

#3993 closed defect (fixed)

Endless loop activating NDS card in fast mode in smargo

Reported by: Mandos Owned by:
Priority: major Component: Reader
Severity: medium Keywords: smartreader fastmode
Cc: Sensitive: no

Description

Revision

r9998

Issue Description

Trying to activate a Smartreader with an NDS card in fast mode (INS7E11 TA1=15) causes an endless card activation loop. See lines 92, 105-107 in the attached log. r9997 works fine with identical setup and config.

When the issue occurs

Starting the reader.

How the issue is reproducable

Start a Smartreader with an NDS card using fast mode (INS7E11 TA1=15)

Attachments (4)

oscam_9998_loop.log (58.4 KB ) - added by Mandos 9 years ago.
fix_v13_fastmode_for_r9998.patch (958 bytes ) - added by Mandos 9 years ago.
This patch fixes smartreader fastmode for V13 (09C4).
oscam_10037_loop.log (56.5 KB ) - added by Mandos 9 years ago.
Log from r10037 - problem still persists
fix_v13_fastmode_for_r10036.patch (992 bytes ) - added by Mandos 9 years ago.
Updated patch (for r10036 and up)

Download all attachments as: .zip

Change History (12)

by Mandos, 9 years ago

Attachment: oscam_9998_loop.log added

comment:1 by bcs, 9 years ago

try ins7e11 = 13

comment:2 by Mandos, 9 years ago

ins7e11=13: same result as ins7e11=15. The reader won’t finish initialization in fast mode.

comment:3 by Winz, 9 years ago

have the same problem v13 = fastmode not work v14 = fastmode works

comment:4 by Mandos, 9 years ago

I think I found the code lines causing the problem. It’s got nothing to do with the switch to CMD_OK and CMD_ERROR to avoid conflicts with the opposed definition of OK and ERROR in reader-common.h, it is another change that causes the loop.

Lines 1631 and 1638 in ifd_smartreader.c (introduced with r9998) define an if... statement, causing the lines inbetween not to be executed if fastmode is set (if I read it correctly, I am not a coder). Anyway, if I remove the two lines 1631 and 1638:

1631    if(!reader->ins7e11_fast_reset){
        ...
1638    }

and compile r10001 for my ET9200 (mipsel-tuxbox toolchain), I get a binary that works in fastmode with the V13 card.

Last edited 9 years ago by Mandos (previous) (diff)

comment:5 by drogon, 9 years ago

same problem on debian server, no card init, version 9997 works

NDS v13 09c4
ins7e11 = 15
smartreader protocoll

by Mandos, 9 years ago

This patch fixes smartreader fastmode for V13 (09C4).

comment:6 by Mandos, 9 years ago

I attached a patch for fixing v13 fastmode in r9998 and later revisions, tested with my v13 card up to r10012 (csctapi/ifd_smartreader.c has not been changed since r9998). Apply in trunk with -p0.

Last edited 9 years ago by Mandos (previous) (diff)

by Mandos, 9 years ago

Attachment: oscam_10037_loop.log added

Log from r10037 - problem still persists

by Mandos, 9 years ago

Updated patch (for r10036 and up)

comment:7 by stefansat sat, 9 years ago

fixed on 10038

comment:8 by Mandos, 9 years ago

Resolution: fixed
Status: newclosed

Fixed - thanks stefansat. Patch not required any more.

Note: See TracTickets for help on using tickets.