Opened 14 years ago
Closed 14 years ago
#963 closed defect (fixed)
config.sh: if disable debug = error on module-dvbapi.c
Reported by: | alborland | Owned by: | alborland |
---|---|---|---|
Priority: | major | Component: | General |
Severity: | medium | Keywords: | |
Cc: | Sensitive: | no |
Description
for testing i disbaled cs_debug in config.sh and try build
but than build error:
In file included from module-dvbapi.c:6:
module-dvbapi.h:188:1: warning: "cs_debug" redefined
In file included from module-dvbapi.c:2:
globals.h:1378:1: warning: this is the location of the previous definition
lib/libcs-mipsel-router-linux-uclibc929.a(module-dvbapi.o): In function `dvbapi_add_emmpid':
module-dvbapi.c:(.text+0x288): undefined reference to `cs_debug'
lib/libcs-mipsel-router-linux-uclibc929.a(module-dvbapi.o): In function `dvbapi_parse_cat':
module-dvbapi.c:(.text+0x410): undefined reference to `cs_debug'
module-dvbapi.c:(.text+0x49c): undefined reference to `cs_debug'
module-dvbapi.c:(.text+0x4fc): undefined reference to `cs_debug'
module-dvbapi.c:(.text+0x574): undefined reference to `cs_debug'
lib/libcs-mipsel-router-linux-uclibc929.a(module-dvbapi.o):module-dvbapi.c:(.text+0x63c): more undefined references to `cs_debug' follow
collect2: ld returned 1 exit status
please correct config.h to set also
module-dvbapi.h:
#ifdef WITH_STAPI
#define cs_log(x...) cs_log("stapi: "x)
#define cs_debug(x...) cs_debug("stapi: "x)
#else
#define cs_log(x...) cs_log("dvbapi: "x)
#define cs_debug(x...) cs_debug("dvbapi: "x)
#endif
to:
#ifdef WITH_STAPI
#define cs_log(x...) cs_log("stapi: "x)
#define cs_debug(x...) cs_debug("stapi: "x)
#else
#define cs_log(x...) cs_log("dvbapi: "x)
#define cs_debug(x...) cs_debug("dvbapi: "x)
#endif
than its ok ;)
Change History (6)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:4 by , 14 years ago
sure but if we work with config.sh it should be correct when disable debug ALL
comment:5 by , 14 years ago
i mean if you already has changed and tested on your end - make a diff and attach here. The next Dev will patch and commit then. If I have to look half an hour for the place to make the change it is not effective ;-)
sorry dammned slow ff.
doubled!